ctap2: establish hmac-secret shared secret without PUAT#365
Open
iiTONELOC wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
authenticatorGetAssertion, CTAP 2.1 section 12.5 has the platform obtain a shared secret before sending thehmac-secretinput.If no PIN/UV auth token is needed and no secret is cached,
get_pin_uv_auth_paramreturnsNoAuthRequired. That skips the existing setup paths, leavingprocess_hmac_secret_and_prf_extensionwith no secret; the requested extension is then omitted without an error.Shared-secret setup now happens immediately before extension processing, limited to CTAP2 authenticators that advertise
hmac-secretand do not already have one cached.cargo test --features crypto_rust --no-default-featurespasses. The added regression reachesNoAuthRequired, establishes the secret, and confirms that the serialized request containshmac-secret.Related: #364